linux-kernel - Re: [patch 1/2] memstick: use after free in msb_disk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1348956554.7401.1.camel@maxim-laptop>
Date:	Sun, 30 Sep 2012 00:09:14 +0200
From:	Maxim Levitsky <maximlevitsky@...il.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jens Axboe <axboe@...nel.dk>
Subject: Re: [patch 1/2] memstick: use after free in msb_disk_release()

On Sat, 2012-09-29 at 10:11 +0300, Dan Carpenter wrote: 
> The original code dereferenced "msb" after freeing it.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> 
> diff --git a/drivers/memstick/core/ms_block.c b/drivers/memstick/core/ms_block.c
> index c815fe5..a8e8915 100644
> --- a/drivers/memstick/core/ms_block.c
> +++ b/drivers/memstick/core/ms_block.c
> @@ -1983,9 +1983,9 @@ static int msb_disk_release(struct gendisk *disk)
>  			msb->usage_count--;
>  
>  		if (!msb->usage_count) {
> -			kfree(msb);
>  			disk->private_data = NULL;
>  			idr_remove(&msb_disk_idr, msb->disk_id);
> +			kfree(msb);
>  			put_disk(disk);
>  		}
>  	}

Oops, I added this bug in latest iteration, when removed support for
major.
Acked-by: Maxim Levitsky <maximlevitsly@...il.com>

Best regards,
Maxim Levitsky

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/