linux-kernel - Re: [patch 2/2] memstick: memory leak on error in msb_ftl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1348956616.7401.2.camel@maxim-laptop>
Date:	Sun, 30 Sep 2012 00:10:16 +0200
From:	Maxim Levitsky <maximlevitsky@...il.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jens Axboe <axboe@...nel.dk>
Subject: Re: [patch 2/2] memstick: memory leak on error in msb_ftl_scan()

On Sat, 2012-09-29 at 10:11 +0300, Dan Carpenter wrote: 
> We need to free "overwrite_flags" before returning.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> 
> diff --git a/drivers/memstick/core/ms_block.c b/drivers/memstick/core/ms_block.c
> index a8e8915..1f9d5cf 100644
> --- a/drivers/memstick/core/ms_block.c
> +++ b/drivers/memstick/core/ms_block.c
> @@ -1408,8 +1408,10 @@ static int msb_ftl_scan(struct msb_data *msb)
>  			msb_mark_block_used(msb, pba);
>  			msb_erase_block(msb, pba);
>  			continue;
> -		} else if (error)
> +		} else if (error) {
> +			kfree(overwrite_flags);
>  			return error;
> +		}
>  
>  		lba = be16_to_cpu(extra.logical_address);
>  		managment_flag = extra.management_flag;

Indeed. I need to be more careful with this,
I'll do another review of the code, maybe I spot anything else.

Acked-by: Maxim Levitsky <maximlevitsly@...il.com>

Best regards,
Maxim Levitsky

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/