linux-kernel - Re: [PATCH] tools lib traceevent: Fix missed freeing of subargs in free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1349098945.22822.113.camel@gandalf.local.home>
Date:	Mon, 01 Oct 2012 09:42:25 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Arnaldo Carvalho de Melo <acme@...radead.org>,
	Ingo Molnar <mingo@...nel.org>
Subject: Re: [PATCH] tools lib traceevent: Fix missed freeing of subargs in
 free_arg() in filter

On Mon, 2012-10-01 at 22:16 +0900, Namhyung Kim wrote:

> Although they have same layout, wouldn't it be better using their own
> fields?
> 
> 	case FILTER_ARG_NUM:
> 		free_arg(arg->num.left);
> 		free_arg(arg->num.right);
> 		break;
> 
> 	case FILTER_ARG_EXP:
> 		free_arg(arg->exp.left);
> 		free_arg(arg->exp.right);
> 		break;

Yeah, I got lazy. This is probably better. I'll resend.

Thanks,

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/