linux-kernel - Re: [PATCH 1/3] Fix trailing whitespace in trace.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1349179923.13371.186.camel@smile>
Date:	Tue, 02 Oct 2012 15:12:03 +0300
From:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:	YAMANE Toshiaki <yamanetoshi@...il.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] Fix trailing whitespace in trace.h

On Tue, 2012-10-02 at 20:53 +0900, YAMANE Toshiaki wrote: 
> fixed below checkpatch error.
> 
> -ERROR: trailing whitespace
> 
> Signed-off-by: Toshiaki Yamane <yamanetoshi@...il.com>
> ---
>  drivers/staging/rts_pstor/trace.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rts_pstor/trace.h b/drivers/staging/rts_pstor/trace.h
> index cf60a1b..740999c 100644
> --- a/drivers/staging/rts_pstor/trace.h
> +++ b/drivers/staging/rts_pstor/trace.h
> @@ -39,7 +39,7 @@ static inline char *filename(char *path)
>  	while (*ptr != '\0') {
>  		if ((*ptr == '\\') || (*ptr == '/'))
>  			path = ptr + 1;
> -		
> +
>  		ptr++;
>  	}

For me it seems total filename() function could be squeezed to just strrchr(path, '/') + 1;
Moreover there is already basename() in the lib/dynamic_debug.c you
could rename, export and reuse.


-- 
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/