[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1349180009.13371.188.camel@smile>
Date: Tue, 02 Oct 2012 15:13:29 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: YAMANE Toshiaki <yamanetoshi@...il.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] Add parenthesis to macros with complex values in
trace.h
On Tue, 2012-10-02 at 20:54 +0900, YAMANE Toshiaki wrote:
> fixed some checkpatch below error.
> -ERROR: Macros with complex values should be enclosed in parenthesis
>
> Signed-off-by: Toshiaki Yamane <yamanetoshi@...il.com>
> ---
> drivers/staging/rts_pstor/trace.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rts_pstor/trace.h b/drivers/staging/rts_pstor/trace.h
> index 740999c..a34493c 100644
> --- a/drivers/staging/rts_pstor/trace.h
> +++ b/drivers/staging/rts_pstor/trace.h
> @@ -78,8 +78,8 @@ do { \
> goto label; \
> } while (0)
> #else
> -#define TRACE_RET(chip, ret) return ret
> -#define TRACE_GOTO(chip, label) goto label
> +#define TRACE_RET(chip, ret) return(ret)
> +#define TRACE_GOTO(chip, label) goto(label)
> #endif
In this specific case I think checkpatch.pl wants more than needed.
--
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists