linux-kernel - Re: [PATCH 02/15] cfq-iosched: More renaming to better represent wl_class and wl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121002132500.GA758@redhat.com>
Date:	Tue, 2 Oct 2012 09:25:00 -0400
From:	Vivek Goyal <vgoyal@...hat.com>
To:	Jeff Moyer <jmoyer@...hat.com>
Cc:	linux-kernel@...r.kernel.org, axboe@...nel.dk, tj@...nel.org,
	cgroups@...r.kernel.org
Subject: Re: [PATCH 02/15] cfq-iosched: More renaming to better represent
 wl_class and wl_type

On Mon, Oct 01, 2012 at 04:50:37PM -0400, Jeff Moyer wrote:
> Vivek Goyal <vgoyal@...hat.com> writes:
> 
> > Also at places I have got rid of keyword "serving" as it is obivious.
> 
> I don't agree with getting rid of serving.  After your patch, it looks
> as though a cfqd has a static workload class and type.  It reads better
> to me the way it is.

It is also about the length of name. To me now a days CFQ code looks
pretty messy with very long names or lines at many a places.

So yes, "cfqd->serving_wl_class" and "cfqd->serving_wl_type" is more
readable than "cfqd->wl_class" and "cfqd->wl_type". But it also 
increases the string length significantly.

I don't know. Some of the strings seem too long and code spills into
multiple lines for a single statement.

Anyway, for this I guess I will retain "serving" keyword.

Thanks
Vivek
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/