linux-kernel - Re: linux-next: build failure after merge of the ubi tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20121003103045.140f3a7a@spider.haslach.nod.at>
Date:	Wed, 3 Oct 2012 10:30:45 +0200
From:	Richard Weinberger <richard@....at>
To:	dedekind1@...il.com
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: linux-next: build failure after merge of the ubi tree

Artem, Stephen,

Am Wed, 03 Oct 2012 10:20:43 +0300
schrieb Artem Bityutskiy <dedekind1@...il.com>:

> On Wed, 2012-10-03 at 12:27 +1000, Stephen Rothwell wrote:
> > Hi Artem,
> > 
> > After merging the ubi tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> > 
> > ERROR: "ubi_update_fastmap" [drivers/mtd/ubi/ubi.ko] undefined!
> > ERROR: "ubi_scan_fastmap" [drivers/mtd/ubi/ubi.ko] undefined!
> > ERROR: "ubi_calc_fm_size" [drivers/mtd/ubi/ubi.ko] undefined!
> 
> I've added Richard's fastmap work there. I'll look at these failures.

Thanks for reporting this.
I'm not sure why this happens with allmodconfig.
If I set CONFIG_MTD=m and CONFIG_MTD_UBI=m it builds fine,
that's how I did most build tests.

The following patch fixes the issue for me.
Artem, are you fine with it?

Thanks,
//richard

---
diff --git a/drivers/mtd/ubi/Makefile b/drivers/mtd/ubi/Makefile
index 7ab19ac..b46b0c97 100644
--- a/drivers/mtd/ubi/Makefile
+++ b/drivers/mtd/ubi/Makefile
@@ -2,6 +2,6 @@ obj-$(CONFIG_MTD_UBI) += ubi.o
 
 ubi-y += vtbl.o vmt.o upd.o build.o cdev.o kapi.o eba.o io.o wl.o
attach.o ubi-y += misc.o debug.o
+ubi-$(CONFIG_MTD_UBI_FASTMAP) += fastmap.o
 
 obj-$(CONFIG_MTD_UBI_GLUEBI) += gluebi.o
-obj-$(CONFIG_MTD_UBI_FASTMAP) += fastmap.o
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/