linux-kernel - Re: [PATCH v2] mfd: da9052-core: Use regmap_irq_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOMZO5AKf0uL9p-cSd7D5XeB6Q9s5EPHDjAgwfkXGGXVLPreMw@mail.gmail.com>
Date:	Wed, 3 Oct 2012 13:04:33 -0300
From:	Fabio Estevam <festevam@...il.com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	Fabio Estevam <fabio.estevam@...escale.com>, sameo@...ux.intel.com,
	Marek Vasut <marex@...x.de>, ashish.jangam@...tcummins.com,
	dchen@...semi.com, arnd@...db.de, kernel@...gutronix.de,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] mfd: da9052-core: Use regmap_irq_get_virq() and fix
 the probe

On Mon, Oct 1, 2012 at 7:22 AM, Mark Brown
<broonie@...nsource.wolfsonmicro.com> wrote:
> On Fri, Sep 28, 2012 at 05:34:18PM -0300, Fabio Estevam wrote:
>
>> +static struct irq_chip da9052_irq_chip = {
>> +     .name                   = "da9052",
>> +     .irq_disable            = da9052_irq_disable,
>> +     .irq_enable             = da9052_irq_enable,
>> +};
>
> I don't understand what this irq_chip or the custom domain you're adding
> are for?

I declared da9052_irq_chip because I do the following:

irq_set_chip_and_handler(virq, &da9052_irq_chip, handle_level_irq);

I am following the arizona-irq approach.

If this is not suitable, can you please point me to some driver that
does not define irq_chip and can still do setup
"irq_set_chip_and_handler()"?

Thanks,

Fabio Estevam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/