linux-kernel - Re: [PATCH v2] mfd: da9052-core: Use regmap_irq_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20121003180808.GH4360@opensource.wolfsonmicro.com>
Date:	Wed, 3 Oct 2012 19:08:08 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Fabio Estevam <festevam@...il.com>
Cc:	Fabio Estevam <fabio.estevam@...escale.com>, sameo@...ux.intel.com,
	Marek Vasut <marex@...x.de>, ashish.jangam@...tcummins.com,
	dchen@...semi.com, arnd@...db.de, kernel@...gutronix.de,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] mfd: da9052-core: Use regmap_irq_get_virq() and fix
 the probe

On Wed, Oct 03, 2012 at 01:04:33PM -0300, Fabio Estevam wrote:
> On Mon, Oct 1, 2012 at 7:22 AM, Mark Brown

> > I don't understand what this irq_chip or the custom domain you're adding
> > are for?

> I declared da9052_irq_chip because I do the following:

> irq_set_chip_and_handler(virq, &da9052_irq_chip, handle_level_irq);

> I am following the arizona-irq approach.

> If this is not suitable, can you please point me to some driver that
> does not define irq_chip and can still do setup
> "irq_set_chip_and_handler()"?

Any other regmap-irq user.  The reason the Arizona driver is doing this
is that it has two interrupt controllers in it, one for the main chip
and one for the always on domain, which is why it registers two
regmap-irq domains.  Notice that there's only two subinterrupts in the
primary domain.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/