linux-kernel - Re: [ 022/180] ioat2: kill pending flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1349362057.16173.27.camel@deadeye.wl.decadent.org.uk>
Date:	Thu, 04 Oct 2012 15:47:37 +0100
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Willy Tarreau <w@....eu>, Dan Williams <dan.j.williams@...el.com>
Cc:	linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [ 022/180] ioat2: kill pending flag

On Tue, 2012-10-02 at 00:52 +0200, Willy Tarreau wrote:
> 2.6.32-longterm review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Dan Williams <dan.j.williams@...el.com>
> 
> commit 281befa5592b0c5f9a3856b5666c62ac66d3d9ee upstream.
> 
> The pending == 2 case no longer exists in the driver so, we can use
> ioat2_ring_pending() outside the lock to determine if there might be any
> descriptors in the ring that the hardware has not seen.
[...]

What bug does this fix?  Is ioat2_ring_pending() *really* safe to call
without the ring_lock?

Ben.

-- 
Ben Hutchings
For every complex problem
there is a solution that is simple, neat, and wrong.

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)