linux-kernel - RE: [PATCH 1/5] rapidio: fix blocking wait for discovery ready

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8D983423E7EDF846BB3056827B8CC5D1499FC794@corpmail2.na.ads.idt.com>
Date:	Thu, 4 Oct 2012 17:20:09 +0000
From:	"Bounine, Alexandre" <Alexandre.Bounine@....com>
To:	Andrew Morton <akpm@...ux-foundation.org>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
	Matt Porter <mporter@...nel.crashing.org>,
	Li Yang <leoli@...escale.com>
Subject: RE: [PATCH 1/5] rapidio: fix blocking wait for discovery ready

On Wed, October 03, 2012 6:20 PM
Andrew Morton <akpm@...ux-foundation.org> wrote:
> 
> On Wed,  3 Oct 2012 15:18:39 -0400
> Alexandre Bounine <alexandre.bounine@....com> wrote:
> 
> > Fix blocking wait loop in the RapidIO discovery routine to avoid
> > warning dumps about stalled CPU on x86 platforms.
> >
> > ...
> >
> > +		to_end = jiffies + CONFIG_RAPIDIO_DISC_TIMEOUT * HZ;
> > +		while (time_before(jiffies, to_end)) {
> > +			if (rio_enum_complete(mport))
> > +				goto enum_done;
> > +
> 	schedule_timeout_uninterruptible(msecs_to_jiffies(10));
> 
> I think a simple msleep(10) would suffice here?
> 
Agree, same thing but looks simpler. Will update.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/