lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 04 Oct 2012 20:48:54 +0200 From: Lars-Peter Clausen <lars@...afoo.de> To: Thierry Reding <thierry.reding@...onic-design.de> CC: linux-kernel@...r.kernel.org, Russell King <linux@....linux.org.uk>, Shawn Guo <shawn.guo@...aro.org>, Eric Miao <eric.y.miao@...il.com>, Haojian Zhuang <haojian.zhuang@...il.com>, Ralf Baechle <ralf@...ux-mips.org>, Dmitry Torokhov <dmitry.torokhov@...il.com>, Bryan Wu <bryan.wu@...onical.com>, Richard Purdie <rpurdie@...ys.net>, Samuel Ortiz <sameo@...ux.intel.com>, Ashish Jangam <ashish.jangam@...tcummins.com>, Andrew Jones <drjones@...hat.com>, linux-arm-kernel@...ts.infradead.org, linux-mips@...ux-mips.org, linux-input@...r.kernel.org, linux-leds@...r.kernel.org Subject: Re: [PATCH] pwm: Get rid of HAVE_PWM On 10/04/2012 08:29 PM, Thierry Reding wrote: > On Thu, Oct 04, 2012 at 05:00:23PM +0200, Lars-Peter Clausen wrote: >> On 10/04/2012 08:06 AM, Thierry Reding wrote: >>> [...] >>> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig >>> index 331d574..b38f23d 100644 >>> --- a/arch/mips/Kconfig >>> +++ b/arch/mips/Kconfig >>> @@ -219,7 +219,8 @@ config MACH_JZ4740 >>> select GENERIC_GPIO >>> select ARCH_REQUIRE_GPIOLIB >>> select SYS_HAS_EARLY_PRINTK >>> - select HAVE_PWM >>> + select PWM >>> + select PWM_JZ4740 >>> select HAVE_CLK >>> select GENERIC_IRQ_CHIP >> >> I'm not sure if this is such a good idea, not all jz4740 based board >> necessarily require PWM. > > This really only restores previous behaviour. But I agree that this is > potentially not what we want. Maybe we should just not select this for > any boards but rather leave it up to some default configuration. If so > the patch can be made simpler by just removing the HAVE_PWM entries. At least for JZ4740 I think that is the better solution. Thanks, - Lars -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists