linux-kernel - re: block: Add driver for Micron RealSSD pcie flash cards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121008071303.GB17400@elgon.mountain>
Date:	Mon, 8 Oct 2012 10:13:03 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	sbradshaw@...ron.com
Cc:	Jens Axboe <axboe@...nel.dk>, linux-kernel@...r.kernel.org
Subject: re: block: Add driver for Micron RealSSD pcie flash cards

Hello Sam Bradshaw,

The patch 88523a61558a: "block: Add driver for Micron RealSSD pcie 
flash cards" from Aug 30, 2011, creates an endian bug:
drivers/block/mtip32xx/mtip32xx.c:2468 mtip_hw_submit_io()

drivers/block/mtip32xx/mtip32xx.c
  2465          fis->opts        = 1 << 7;
  2466          fis->command     =
  2467                  (dir == READ ? ATA_CMD_FPDMA_READ : ATA_CMD_FPDMA_WRITE);
  2468          *((unsigned int *) &fis->lba_low) = (start & 0xFFFFFF);
                                    ^^^^^^^^^^^^
  2469          *((unsigned int *) &fis->lba_low_ex) = ((start >> 24) & 0xFFFFFF);
                                    ^^^^^^^^^^^^^^^

These addresses point to a series of four unions inside the
host_to_dev_fis struct.  The unions will be set to different values
depending on if the CPU is big or little endian.

If you knew which endianness this works on, then you could probably add
a cpu_to_be32() or cpu_to_le32().

  2470          fis->device      = 1 << 6;
  2471          fis->features    = nsect & 0xFF;

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/