linux-kernel - Re: [PATCH] Do not use cpu_to_node() to find an offlined cpu's node.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1349780256.7880.12.camel@twins>
Date:	Tue, 09 Oct 2012 12:57:36 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Tang Chen <tangchen@...fujitsu.com>
Cc:	mingo@...hat.com, miaox@...fujitsu.com, wency@...fujitsu.com,
	linux-kernel@...r.kernel.org, linux-numa@...r.kernel.org,
	David Rientjes <rientjes@...gle.com>
Subject: Re: [PATCH] Do not use cpu_to_node() to find an offlined cpu's node.

On Mon, 2012-10-08 at 10:59 +0800, Tang Chen wrote:
> If a cpu is offline, its nid will be set to -1, and cpu_to_node(cpu) will
> return -1. As a result, cpumask_of_node(nid) will return NULL. In this case,
> find_next_bit() in for_each_cpu will get a NULL pointer and cause panic.

Hurm,. this is new, right? Who is changing all these semantics without
auditing the tree and informing all affected people?


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/