linux-kernel - Re: PRJQUOTA case not handled in need_print

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121009214227.GC27882@quack.suse.cz>
Date:	Tue, 9 Oct 2012 23:42:27 +0200
From:	Jan Kara <jack@...e.cz>
To:	Jiri Kosina <jkosina@...e.cz>
Cc:	"Eric W. Biederman" <ebiederm@...ssion.com>,
	linux-kernel@...r.kernel.org, Dave Chinner <david@...morbit.com>,
	Jan Kara <jack@...e.cz>
Subject: Re: PRJQUOTA case not handled in need_print_warning()

On Fri 05-10-12 00:34:29, Jiri Kosina wrote:
> Hi,
> 
> commit e8a3e4719b7ec19288c56f22623f537cb78885c1
> Author: Eric W. Biederman <ebiederm@...ssion.com>
> Date:   Sun Sep 16 01:11:45 2012 -0700
> 
>     userns: Implement struct kqid
> 
> causes this warning:
> 
> fs/quota/dquot.c: In function ‘need_print_warning’:
> fs/quota/dquot.c:1158: warning: enumeration value ‘PRJQUOTA’ not handled in switch
> 
> and it seems to be a valid one -- the switch in need_print_warning() 
> contains neither 'default' nor PRJQUOTA case handler.
  Hum, since Eric didn't seem to care, I've fixed this up myself with the
attached patch. Actually, PRJQUOTA should never get to that function so it
shouldn't cause any problems in practice. Thanks for the report.

								Honza

View attachment "0001-quota-Silence-warning-about-PRJQUOTA-not-being-handl.patch" of type "text/x-patch" (1016 bytes)