linux-kernel - Re: [PATCH 2/3] lglock: make the per

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20121009144617.7d7862b1.akpm@linux-foundation.org>
Date:	Tue, 9 Oct 2012 14:46:17 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Lai Jiangshan <laijs@...fujitsu.com>
Cc:	linux-kernel@...r.kernel.org, Al Viro <viro@...iv.linux.org.uk>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH 2/3] lglock: make the per_cpu locks static

On Tue, 9 Oct 2012 11:46:39 +0800
Lai Jiangshan <laijs@...fujitsu.com> wrote:

> The per_cpu locks are not used outside nor exported.
> Add a "static" linkage keyword to it.

I think a better description is:

: The per_cpu locks are not used outside the file which contains the
: DEFINE_LGLOCK(), so we can make these symbols static.

> --- a/include/linux/lglock.h
> +++ b/include/linux/lglock.h
> @@ -49,7 +49,7 @@ struct lglock {
>  };
>  
>  #define DEFINE_LGLOCK(name)						\
> -	DEFINE_PER_CPU(arch_spinlock_t, name ## _lock)			\
> +	static DEFINE_PER_CPU(arch_spinlock_t, name ## _lock)		\
>  	= __ARCH_SPIN_LOCK_UNLOCKED;					\
>  	struct lglock name = { .lock = &name ## _lock }
>  
> -- 
> 1.7.4.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/