linux-kernel - Re: [RESEND PATCH] scsi: make struct scsi_varlen_cdb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5076990C.4080406@acm.org>
Date:	Thu, 11 Oct 2012 12:01:48 +0200
From:	Bart Van Assche <bvanassche@....org>
To:	James Hogan <james.hogan@...tec.com>
CC:	"James E.J. Bottomley" <JBottomley@...allels.com>,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH] scsi: make struct scsi_varlen_cdb_hdr packed

On 10/11/12 11:15, James Hogan wrote:
> The struct scsi_varlen_cdb_hdr is expected to be exactly 10 bytes when
> used in struct osd_cdb_head, but it isn't marked as packed. Some
> architectures will round the struct size up which triggers BUILD_BUG_ON
> compile errors in osd_initiator.c when the outer structs are unexpected
> sizes. This is fixed by marking struct scsi_varlen_cdb_hdr as __packed.
>
> Signed-off-by: James Hogan <james.hogan@...tec.com>
> ---
>   include/scsi/scsi.h |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/include/scsi/scsi.h b/include/scsi/scsi.h
> index 66216c1..3beaef3 100644
> --- a/include/scsi/scsi.h
> +++ b/include/scsi/scsi.h
> @@ -198,7 +198,7 @@ struct scsi_varlen_cdb_hdr {
>   	__u8 additional_cdb_length;         /* total cdb length - 8 */
>   	__be16 service_action;
>   	/* service specific data follows */
> -};
> +} __packed;
>
>   static inline unsigned
>   scsi_varlen_cdb_length(const void *hdr)

Hello James,

Are you aware that __packed can also be used on individual struct 
members and that doing so has a lower performance penalty than using the 
__packed attribute on an entire struct ? See e.g. <linux/sysv_fs.h> for 
an example.

Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/