linux-kernel - Re: [PATCH 06/22] ocfs2: drop vmtruncate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <507A93C4.8020509@gmail.com>
Date:	Sun, 14 Oct 2012 12:28:20 +0200
From:	Marco Stornelli <marco.stornelli@...il.com>
To:	Christoph Hellwig <hch@...radead.org>
CC:	Al Viro <viro@...IV.linux.org.uk>, Mark Fasheh <mfasheh@...e.com>,
	Joel Becker <jlbec@...lplan.org>, ocfs2-devel@....oracle.com,
	linux-kernel@...r.kernel.org,
	Linux FS Devel <linux-fsdevel@...r.kernel.org>
Subject: Re: [PATCH 06/22] ocfs2: drop vmtruncate

Il 13/10/2012 18:19, Christoph Hellwig ha scritto:
>>   	if ((attr->ia_valid & ATTR_SIZE) &&
>>   	    attr->ia_size != i_size_read(inode)) {
>> -		status = vmtruncate(inode, attr->ia_size);
>> +		status = inode_newsize_ok(inode, attr->ia_size);
>>   		if (status) {
>>   			mlog_errno(status);
>>   			goto bail_commit;
>>   		}
>> +		truncate_setsize(inode, attr->ia_size);
>
> ocfs2 already calls inode_newsize_ok earlier during ocfs2_setattr,
> and there's an XXX comment just above the vmtruncate call about
> how ocfs2 hacks around this.  I suspect you just want a plain
> truncate_setsize here and remove the comment above it, but I'd
> like to have the ocfs2 folks confirm that.
>
>

Yep, I quite agree. truncate_setsize can be moved up into to the 
previous "if (size_change && attr->ia_size != i_size_read(inode))" where 
the truncate code does its work.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/