linux-kernel - Re: [PATCH] staging: csr: fix coding style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <507D08FE.4070902@bluegiga.com>
Date:	Tue, 16 Oct 2012 10:13:02 +0300
From:	Lauri Hintsala <lauri.hintsala@...egiga.com>
To:	SeongJae Park <sj38.park@...il.com>
CC:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: csr: fix coding style

Hi,

On 10/15/2012 10:55 AM, SeongJae Park wrote:
> Fix coding style of csr_framework_ext_types.h
>
> Signed-off-by: SeongJae Park <sj38.park@...il.com>
> ---
>   drivers/staging/csr/csr_framework_ext_types.h |   33 +++++++++++--------------
>   1 file changed, 15 insertions(+), 18 deletions(-)
>
> diff --git a/drivers/staging/csr/csr_framework_ext_types.h b/drivers/staging/csr/csr_framework_ext_types.h
> index 57194ee..7e9cf8e 100644
> --- a/drivers/staging/csr/csr_framework_ext_types.h
> +++ b/drivers/staging/csr/csr_framework_ext_types.h
> @@ -2,11 +2,11 @@

...

> @@ -24,17 +24,15 @@ extern "C" {
>
>   #ifdef __KERNEL__
>
> -struct CsrThread
> -{
> -    struct task_struct *thread_task;
> -    char                name[16];
> +struct CsrThreadi {


I think this extra i letter at the end of CsrThreadi string is typo. Did 
you try to compile the driver with your changes?

Best regards,
Lauri Hintsala


> +	struct task_struct *thread_task;
> +	char                name[16];

...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/