linux-kernel - Re: [PATCH] staging: csr: fix coding style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121022205626.GA4368@kroah.com>
Date:	Mon, 22 Oct 2012 13:56:26 -0700
From:	Greg KH <greg@...ah.com>
To:	Lauri Hintsala <lauri.hintsala@...egiga.com>
Cc:	SeongJae Park <sj38.park@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: csr: fix coding style

On Tue, Oct 16, 2012 at 10:13:02AM +0300, Lauri Hintsala wrote:
> Hi,
> 
> On 10/15/2012 10:55 AM, SeongJae Park wrote:
> >Fix coding style of csr_framework_ext_types.h
> >
> >Signed-off-by: SeongJae Park <sj38.park@...il.com>
> >---
> >  drivers/staging/csr/csr_framework_ext_types.h |   33 +++++++++++--------------
> >  1 file changed, 15 insertions(+), 18 deletions(-)
> >
> >diff --git a/drivers/staging/csr/csr_framework_ext_types.h b/drivers/staging/csr/csr_framework_ext_types.h
> >index 57194ee..7e9cf8e 100644
> >--- a/drivers/staging/csr/csr_framework_ext_types.h
> >+++ b/drivers/staging/csr/csr_framework_ext_types.h
> >@@ -2,11 +2,11 @@
> 
> ...
> 
> >@@ -24,17 +24,15 @@ extern "C" {
> >
> >  #ifdef __KERNEL__
> >
> >-struct CsrThread
> >-{
> >-    struct task_struct *thread_task;
> >-    char                name[16];
> >+struct CsrThreadi {
> 
> 
> I think this extra i letter at the end of CsrThreadi string is typo.
> Did you try to compile the driver with your changes?

Turns out that no one uses 'struct CsrThread' anywhere, so this didn't
break the build.

But, it's incorrect, I'll fix it up by hand.

SeongJae, care to send a follow-on patch that just removes the whole
structure?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/