lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 16 Oct 2012 10:40:26 +0200 From: Lars-Peter Clausen <lars@...afoo.de> To: Lars Poeschel <larsi@....tu-dresden.de> CC: sameo@...ux.intel.com, linux-kernel@...r.kernel.org, jic23@....ac.uk, khali@...ux-fr.org, ben-linux@...ff.org, w.sang@...gutronix.de, grant.likely@...retlab.ca, linus.walleij@...aro.org, Lars Poeschel <poeschel@...onage.de> Subject: Re: [PATCH v2 1/4] mfd: add viperboard driver On 10/12/2012 04:34 PM, Lars Poeschel wrote: > [...] > +static void vprbrd_dev_release(struct device *dev) > +{ > + return; A empty release callback is usually a good indicator that something is wrong. The release callback will be called once the last reference to the device has been called, so the memory associated with the device should not be freed before the release callback has been called, otherwise the memory might be accessed after it has been freed... > +} > + > +static void vprbrd_free(struct vprbrd *dev) > +{ > + usb_put_dev(dev->usb_dev); > + kfree(dev); ..., so this kfree should be moved from here to the release callback. Btw. I'm wondering why is the extra platform device required? Can't you not just use the usb device as the parent device for the mfd cells? > +} > [...][ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists