linux-kernel - Re: [PATCH V2 RESEND] gpio: samsung: use pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <507D2C3C.8050706@gmail.com>
Date:	Tue, 16 Oct 2012 20:43:24 +1100
From:	Ryan Mallon <rmallon@...il.com>
To:	Jingoo Han <jg1.han@...sung.com>
CC:	'Grant Likely' <grant.likely@...retlab.ca>,
	'Linus Walleij' <linus.walleij@...aro.org>,
	'Kukjin Kim' <kgene.kim@...sung.com>,
	linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2 RESEND] gpio: samsung: use pr_* instead of printk

On 16/10/12 19:25, Jingoo Han wrote:

> This patch uses pr_* instead of printk. Also, gpio_dbg
> is replaced with pr_debug.
> 
> Signed-off-by: Ryan Mallon <rmallon@...il.com>


If I recall correctly, I only offered review comments on this patch,
I wasn't directly involved in writing it, or in the submission
process, so you don't need to have my signed-off-by here.  It's also
generally considered impolite to add someone's signed-off-by without
asking for permission. I don't mind either way, but you don't need
my tag since you wrote the patch, I only provided feedback.

Thanks,
~Ryan

> Signed-off-by: Jingoo Han <jg1.han@...sung.com>
> Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
> ---
>  drivers/gpio/gpio-samsung.c |   18 ++++++------------
>  1 files changed, 6 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/gpio/gpio-samsung.c b/drivers/gpio/gpio-samsung.c
> index a006f0d..5c5ccdf 100644
> --- a/drivers/gpio/gpio-samsung.c
> +++ b/drivers/gpio/gpio-samsung.c
> @@ -42,12 +42,6 @@
>  #include <plat/gpio-fns.h>
>  #include <plat/pm.h>
>  
> -#ifndef DEBUG_GPIO
> -#define gpio_dbg(x...) do { } while (0)
> -#else
> -#define gpio_dbg(x...) printk(KERN_DEBUG x)
> -#endif
> -
>  int samsung_gpio_setpull_updown(struct samsung_gpio_chip *chip,
>  				unsigned int off, samsung_gpio_pull_t pull)
>  {
> @@ -599,7 +593,7 @@ static int samsung_gpiolib_4bit_input(struct gpio_chip *chip,
>  	con &= ~(0xf << con_4bit_shift(offset));
>  	__raw_writel(con, base + GPIOCON_OFF);
>  
> -	gpio_dbg("%s: %p: CON now %08lx\n", __func__, base, con);
> +	pr_debug("%s: %p: CON now %08lx\n", __func__, base, con);
>  
>  	return 0;
>  }
> @@ -627,7 +621,7 @@ static int samsung_gpiolib_4bit_output(struct gpio_chip *chip,
>  	__raw_writel(con, base + GPIOCON_OFF);
>  	__raw_writel(dat, base + GPIODAT_OFF);
>  
> -	gpio_dbg("%s: %p: CON %08lx, DAT %08lx\n", __func__, base, con, dat);
> +	pr_debug("%s: %p: CON %08lx, DAT %08lx\n", __func__, base, con, dat);
>  
>  	return 0;
>  }
> @@ -671,7 +665,7 @@ static int samsung_gpiolib_4bit2_input(struct gpio_chip *chip,
>  	con &= ~(0xf << con_4bit_shift(offset));
>  	__raw_writel(con, regcon);
>  
> -	gpio_dbg("%s: %p: CON %08lx\n", __func__, base, con);
> +	pr_debug("%s: %p: CON %08lx\n", __func__, base, con);
>  
>  	return 0;
>  }
> @@ -706,7 +700,7 @@ static int samsung_gpiolib_4bit2_output(struct gpio_chip *chip,
>  	__raw_writel(con, regcon);
>  	__raw_writel(dat, base + GPIODAT_OFF);
>  
> -	gpio_dbg("%s: %p: CON %08lx, DAT %08lx\n", __func__, base, con, dat);
> +	pr_debug("%s: %p: CON %08lx, DAT %08lx\n", __func__, base, con, dat);
>  
>  	return 0;
>  }
> @@ -926,10 +920,10 @@ static void __init samsung_gpiolib_add(struct samsung_gpio_chip *chip)
>  #ifdef CONFIG_PM
>  	if (chip->pm != NULL) {
>  		if (!chip->pm->save || !chip->pm->resume)
> -			printk(KERN_ERR "gpio: %s has missing PM functions\n",
> +			pr_err("gpio: %s has missing PM functions\n",
>  			       gc->label);
>  	} else
> -		printk(KERN_ERR "gpio: %s has no PM function\n", gc->label);
> +		pr_err("gpio: %s has no PM function\n", gc->label);
>  #endif
>  
>  	/* gpiochip_add() prints own failure message on error. */


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/