linux-kernel - Re: Fix memory leak in binder--version2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMP5XgeEKbAEj4RB4BRgPravPzPt4K=9kvNTsjR8Ets2dQjDrQ@mail.gmail.com>
Date:	Tue, 16 Oct 2012 15:33:03 -0700
From:	Arve Hjønnevåg <arve@...roid.com>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	"Tu, Xiaobing" <xiaobing.tu@...el.com>,
	"ccross@...roid.com" <ccross@...roid.com>,
	"davej@...hat.com" <davej@...hat.com>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"mingo@...e.hu" <mingo@...e.hu>,
	"rusty@...tcorp.com.au" <rusty@...tcorp.com.au>,
	"a.p.zijlstra@...llo.nl" <a.p.zijlstra@...llo.nl>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"rostedt@...dmis.org" <rostedt@...dmis.org>,
	"Zhang, Di" <di.zhang@...el.com>,
	"Ma, Xindong" <xindong.ma@...el.com>,
	"Zuo, Alex" <alex.zuo@...el.com>
Subject: Re: Fix memory leak in binder--version2

On Tue, Oct 16, 2012 at 12:11 AM, Greg KH <gregkh@...uxfoundation.org> wrote:
> On Mon, Oct 15, 2012 at 05:39:22PM -0700, Arve Hjønnevåg wrote:
>> On Mon, Oct 15, 2012 at 4:58 PM, Greg KH <gregkh@...uxfoundation.org> wrote:
>> > On Mon, Oct 15, 2012 at 04:55:21PM -0700, Arve Hjønnevåg wrote:
>> >> On Mon, Oct 15, 2012 at 3:52 PM, Greg KH <gregkh@...uxfoundation.org> wrote:
>> >> > On Mon, Oct 15, 2012 at 07:20:01AM +0000, Tu, Xiaobing wrote:
>> >> >> After enabling kmemleak and run monkey, following memleak is reported:
>> >> >> unreferenced object 0xeed27f80 (size 64):
>> >> >>   comm "Binder_8", pid 641, jiffies 4294946341 (age 2275.810s)
>> >> >>   hex dump (first 32 bytes):
>> >> >>     4f dd 00 00 84 7f d2 ee 84 7f d2 ee 01 00 00 00  O...............
>> >> >>     00 00 00 00 00 00 00 00 00 aa 4c d7 00 00 00 00  ..........L.....
>> >> >>   backtrace:
>> >> >>     [<c184fabc>] kmemleak_alloc+0x3c/0xa0
>> >> >>     [<c12f391e>] kmem_cache_alloc_trace+0x9e/0x180
>> >> >>     [<c1668bb5>] binder_thread_write+0xcf5/0x23a0
>> >> >>     [<c166b091>] binder_ioctl+0x1f1/0x530
>> >> >>     [<c130dcf6>] do_vfs_ioctl+0x86/0x5e0
>> >> >>     [<c130e282>] sys_ioctl+0x32/0x60
>> >> >>     [<c1872e01>] syscall_call+0x7/0xb
>> >> >>     [<ffffffff>] 0xffffffff
>> >> >>
>> >> >> The work item in async_todo list is not freed when binder released.
>> >> >> Also the async transaction should also be freed in binder_release_work.
>> >> >>
>> >> >> Signed-off-by: Leon Ma <xindong.ma@...el.com>
>> >> >> Signed-off-by: Di Zhang <di.zhang@...el.com>
>> >> >> ---
>> >> >>  drivers/staging/android/binder.c |    6 ++++++
>> >> >>  1 files changed, 6 insertions(+), 0 deletions(-)
>> >> >
>> >> > Nice fix, but next time can you at least use scripts/get_maintainer.pl
>> >> > to figure out who to send this to?  I'll queue it up soon, but it took
>> >> > akpm to point me at this for me to notice it.
>> >>
>> >> This patch was just pointer out to me as well. I have a similar fix
>> >> queued up at https://android-review.googlesource.com/#/c/43801/ that
>> >> is still being tested. It fixes this leak and a theoretical leak of
>> >> death notification objects.
>> >
>> > Ok, should I hold off applying this patch and wait for your patch
>> > instead?
>> >
>>
>> I just sent two patches, but they are not fully tested yet.
>
> Ok, care to test them and after that, resend them with the changes I
> noted in the changelog section of the patch?
>

All the new cleanup code has been tested now. I also included two
older patches that are not in mainline.

-- 
Arve Hjønnevåg
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/