linux-kernel - Re: [PATCH 1/2] Staging: android: binder: Fix memory leak on thread/process exit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMP5XgfVPeN8CRwKxeTv6fL8M0MXV56R+GrWw88caVZrQfu+Vg@mail.gmail.com>
Date:	Tue, 16 Oct 2012 15:45:20 -0700
From:	Arve Hjønnevåg <arve@...roid.com>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	xiaobing.tu@...el.com, ccross@...roid.com, davej@...hat.com,
	akpm@...ux-foundation.org, mingo@...e.hu, rusty@...tcorp.com.au,
	a.p.zijlstra@...llo.nl, linux-kernel@...r.kernel.org,
	rostedt@...dmis.org, di.zhang@...el.com, xindong.ma@...el.com,
	alex.zuo@...el.com
Subject: Re: [PATCH 1/2] Staging: android: binder: Fix memory leak on
 thread/process exit

On Tue, Oct 16, 2012 at 12:11 AM, Greg KH <gregkh@...uxfoundation.org> wrote:
> On Mon, Oct 15, 2012 at 05:32:41PM -0700, Arve Hjønnevåg wrote:
>> If a thread or process exited while a reply, one-way transaction or
>> death notification was pending, the struct holding the pending work
>> was leaked.
>>
>> Change-Id: I2eaafaba1c0ecda3ec0872d449dc16d0721c21e7
>
> What is this field?  Please don't include this in kernel patches, it
> forces me to edit the patch by hand :(
>

It is a tag generated a git hook to uniquely identify a change through
multiple revisions of that change. If the tag does not already exist
the hook adds it. I removed it from the reposted patches as you
requested, but have you considered leaving it in? It is a useful
search token both for finding different revisions of a patch and for
finding which branch a change has been cherry-picked into.

> Also, this should go to older kernels, right?

It can, but the leak is relatively slow so I don't think it is
critical. I looked at one device that had been running for a while and
it had leaked around 16k per month.

-- 
Arve Hjønnevåg
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/