linux-kernel - RE: [PATCH] x86/ioapic: fix the irq_2_pin mem leak when destroy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <27240C0AC20F114CBF8149A2696CBE4A1A18B9@SHSMSX101.ccr.corp.intel.com>
Date:	Wed, 17 Oct 2012 03:36:12 +0000
From:	"Liu, Chuansheng" <chuansheng.liu@...el.com>
To:	Yinghai Lu <yinghai@...nel.org>
CC:	"tglx@...utronix.de" <tglx@...utronix.de>,
	"mingo@...hat.com" <mingo@...hat.com>,
	"Siddha, Suresh B" <suresh.b.siddha@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] x86/ioapic: fix the irq_2_pin mem leak when destroy_irq

> -----Original Message-----
> From: yhlu.kernel@...il.com [mailto:yhlu.kernel@...il.com] On Behalf Of
> Yinghai Lu
> Sent: Wednesday, October 17, 2012 10:03 AM
> To: Liu, Chuansheng
> Cc: tglx@...utronix.de; mingo@...hat.com; Siddha, Suresh B;
> linux-kernel@...r.kernel.org
> Subject: Re: [PATCH] x86/ioapic: fix the irq_2_pin mem leak when destroy_irq
> 
> On Wed, Oct 17, 2012 at 3:11 AM, Chuansheng Liu
> <chuansheng.liu@...el.com> wrote:
> >
> > When destroying the irq, before free cfg, need to check
> > cfg->irq_2_pin and free it when it is not NULL.
> >
> > Signed-off-by: liu chuansheng <chuansheng.liu@...el.com>
> > ---
> 
> i had that in another patch...
> 
> https://lkml.org/lkml/2012/2/23/574
Sorry to not know that.
> 
> ----
> Subject	[PATCH 01/13] x86, irq: Convert irq_2_pin list to generic list
> Date	Thu, 23 Feb 2012 19:48:47 -0800
> 
> So we can use generic list helper function.
Does it really need the generic list with both prev and next pointers?
For irq_2_pin list, the next pointer seems be enough.

> 
> Also make free_irq_cfg() free irq_2_pin list.
> ----
> 
> http://git.kernel.org/?p=linux/kernel/git/yinghai/linux-yinghai.git;a=commitdiff;
> h=4010f4dbd1b172e3080d3e6c459a58c4b575f081
> 
> Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/