linux-kernel - Re: [PATCH] Make uapi/linux/irqnr.h non-empty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 17 Oct 2012 09:07:03 +0530
From:	viresh kumar <viresh.kumar@...aro.org>
To:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Arnd Bergmann <arnd@...db.de>
Cc:	David Howells <dhowells@...hat.com>, linux-kernel@...r.kernel.org,
	Randy Dunlap <rdunlap@...otime.net>,
	Alessandro Suardi <alessandro.suardi@...il.com>,
	Michal Marek <mmarek@...e.cz>,
	spear-devel <spear-devel@...t.st.com>
Subject: Re: [PATCH] Make uapi/linux/irqnr.h non-empty

On Wed, Oct 17, 2012 at 7:33 AM, Linus Torvalds
<torvalds@...ux-foundation.org> wrote:

> Some of the empty files seem pointless. The
>
>   arch/arm/mach-spear13xx/include/mach/spear1310_misc_regs.h
>
> file, for example, has always been empty, and does not seem to be actually used.
>
> Hmm? I added a few more people to the cc list.

Shocked :)
I never realized these files were added by my commit and it never got caught in
reviews :(

Probably because git log --stat or git show (stat part) doesn't show
files with zero
changes. Probably need to fix that too?

@Arnd: Can you please apply following patch to fix SPEAr's issues
point out by Linus?

------------------------x-------------------x------------------------

From: Viresh Kumar <viresh.kumar@...aro.org>
Date: Wed, 17 Oct 2012 08:58:08 +0530
Subject: [PATCH] ARM: SPEAr: Remove unused empty files

Few empty files (spear1310_misc_regs.h and spear1340_misc_regs.h) are created by
commit:

commit b31e23726bb9d6cd8848fc539b23330769830110
Author: Viresh Kumar <viresh.kumar@...com>
Date:   Thu Apr 19 22:23:13 2012 +0530

    SPEAr13xx: Add header files

Don't know how they got added, obviously my fault :)
But nobody could even catch them in reviews.

Remove them.

Signed-off-by: Viresh Kumar <viresh.kumar@...aro.org>
---
 0 files changed
 delete mode 100644 arch/arm/mach-spear13xx/include/mach/spear1310_misc_regs.h
 delete mode 100644 arch/arm/mach-spear13xx/include/mach/spear1340_misc_regs.h

diff --git a/arch/arm/mach-spear13xx/include/mach/spear1310_misc_regs.h
b/arch/arm/mach-spear13xx/include/mach/spear1310_misc_regs.h
deleted file mode 100644
index e69de29..0000000
diff --git a/arch/arm/mach-spear13xx/include/mach/spear1340_misc_regs.h
b/arch/arm/mach-spear13xx/include/mach/spear1340_misc_regs.h
deleted file mode 100644
index e69de29..0000000
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/