[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1350567209.2460.145.camel@zakaz.uk.xensource.com>
Date: Thu, 18 Oct 2012 14:33:29 +0100
From: Ian Campbell <Ian.Campbell@...rix.com>
To: Stefano Stabellini <Stefano.Stabellini@...citrix.com>
CC: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
Mukesh Rathor <mukesh.rathor@...cle.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"xen-devel@...ts.xen.org" <xen-devel@...ts.xen.org>
Subject: Re: [PATCH 5/6] xen: arm: implement remap interfaces needed for
privcmd mappings.
On Thu, 2012-10-18 at 14:27 +0100, Stefano Stabellini wrote:
> On Wed, 17 Oct 2012, Ian Campbell wrote:
> > We use XENMEM_add_to_physmap_range which is the preferred interface
> > for foreign mappings.
> >
> > Signed-off-by: Ian Campbell <ian.campbell@...rix.com>
>
> It looks OK but there are few code style issues, please run the patch
> through checkpatch.
The only one I get is:
WARNING: please, no spaces at the start of a line
#83: FILE: include/xen/interface/memory.h:175:
+ uint16_t size;$
total: 0 errors, 1 warnings, 64 lines checked
The prevailing indentation in that file is 4 spaces so I think we should
ignore the warning in this case in the interests of consistency with the
surrounding code.
Ian.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists