linux-kernel - Re: [PATCH 5/6] xen: arm: implement remap interfaces needed for privcmd mappings.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1210181434420.2689@kaball.uk.xensource.com>
Date:	Thu, 18 Oct 2012 14:35:51 +0100
From:	Stefano Stabellini <stefano.stabellini@...citrix.com>
To:	Ian Campbell <Ian.Campbell@...rix.com>
CC:	Stefano Stabellini <Stefano.Stabellini@...citrix.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
	Mukesh Rathor <mukesh.rathor@...cle.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"xen-devel@...ts.xen.org" <xen-devel@...ts.xen.org>
Subject: Re: [PATCH 5/6] xen: arm: implement remap interfaces needed for
 privcmd mappings.

On Thu, 18 Oct 2012, Ian Campbell wrote:
> On Thu, 2012-10-18 at 14:27 +0100, Stefano Stabellini wrote:
> > On Wed, 17 Oct 2012, Ian Campbell wrote:
> > > We use XENMEM_add_to_physmap_range which is the preferred interface
> > > for foreign mappings.
> > > 
> > > Signed-off-by: Ian Campbell <ian.campbell@...rix.com>
> > 
> > It looks OK but there are few code style issues, please run the patch
> > through checkpatch.
> 
> The only one I get is:
> WARNING: please, no spaces at the start of a line
> #83: FILE: include/xen/interface/memory.h:175:
> +    uint16_t    size;$
> 
> total: 0 errors, 1 warnings, 64 lines checked
> 
> The prevailing indentation in that file is 4 spaces so I think we should
> ignore the warning in this case in the interests of consistency with the
> surrounding code.

Strange, I get:

ERROR: spaces required around that '=' (ctx:VxV)
#140: FILE: arch/arm/xen/enlighten.c:130:
+       for (i=0; i<nr; i++) {
              ^

ERROR: spaces required around that '<' (ctx:VxV)
#140: FILE: arch/arm/xen/enlighten.c:130:
+       for (i=0; i<nr; i++) {
                   ^

WARNING: please, no spaces at the start of a line
#185: FILE: include/xen/interface/memory.h:196:
+    domid_t domid;$

WARNING: please, no spaces at the start of a line
#186: FILE: include/xen/interface/memory.h:197:
+    uint16_t space; /* => enum phys_map_space */$

WARNING: please, no spaces at the start of a line
#189: FILE: include/xen/interface/memory.h:200:
+    uint16_t size;$

WARNING: please, no spaces at the start of a line
#190: FILE: include/xen/interface/memory.h:201:
+    domid_t foreign_domid; /* IFF gmfn_foreign */$

WARNING: please, no spaces at the start of a line
#193: FILE: include/xen/interface/memory.h:204:
+    GUEST_HANDLE(xen_ulong_t) idxs;$

WARNING: please, no spaces at the start of a line
#196: FILE: include/xen/interface/memory.h:207:
+    GUEST_HANDLE(xen_pfn_t) gpfns;$

total: 2 errors, 6 warnings, 162 lines checked



The ones that bother me a bit are:

+       for (i=0; i<nr; i++) {

that should be

+       for (i = 0; i < nr; i++) {
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/