linux-kernel - Re: [PATCH 2/2] rename NUMA fault handling functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121019205407.GA9132@gmail.com>
Date:	Fri, 19 Oct 2012 22:54:07 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Rik van Riel <riel@...hat.com>
Cc:	Peter Zijlstra <a.p.zijlstra@...llo.nl>, mingo@...hat.com,
	linux-kernel@...r.kernel.org, aarcange@...hat.com,
	Michel Lespinasse <walken@...gle.com>
Subject: Re: [PATCH 2/2] rename NUMA fault handling functions


* Rik van Riel <riel@...hat.com> wrote:

> On 10/19/2012 07:41 AM, Peter Zijlstra wrote:
> >On Thu, 2012-10-18 at 17:20 -0400, Rik van Riel wrote:
> >>Having the function name indicate what the function is used
> >>for makes the code a little easier to read.  Furthermore,
> >>the fault handling code largely consists of do_...._page
> >>functions.
> >
> > I don't much care either way, but I was thinking walken 
> > might want to use something similar to do WSS estimation, in 
> > which case the NUMA name is just as wrong.
> 
> That's a good point. I had not considered other uses of the 
> same code.

Renaming the functions for more clarity still makes sense IMO: 
we could give it a _wss or _working_set prefix/postfix?

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/