linux-kernel - re: sched, numa, mm: Implement constant, per task Working Set Sampling (WSS) rate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121022115545.GA631@elgon.mountain>
Date:	Mon, 22 Oct 2012 14:55:46 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	a.p.zijlstra@...llo.nl
Cc:	linux-kernel@...r.kernel.org
Subject: re: sched, numa, mm: Implement constant, per task Working Set
 Sampling (WSS) rate

Hello Peter Zijlstra,

The patch 3d049f8a5398: "sched, numa, mm: Implement constant, per
task Working Set Sampling (WSS) rate" from Oct 14, 2012, leads to the
following warning:
kernel/sched/fair.c:954 task_numa_work()
	 error: we previously assumed 'vma' could be null (see line 948)

   943          if (!vma) {
   944                  ACCESS_ONCE(mm->numa_scan_seq)++;
   945                  offset = 0;
   946                  vma = mm->mmap;
   947          }
   948          while (vma && !vma_migratable(vma)) {
                       ^^^
If this is NULL,
   949                  vma = vma->vm_next;
   950                  if (!vma)
   951                          goto again;
   952          }
   953  
   954          offset = max(offset, vma->vm_start);
                                     ^^^^^^^^^^^^^
then it leads to a NULL dereference here.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/