linux-kernel - Re: [PATCH] aoe: remove unused variable in resend()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DFBFBFD3-4B29-4233-B109-C6AFFB57BBF2@coraid.com>
Date:	Mon, 22 Oct 2012 14:56:32 -0500
From:	Ed Cashin <ecashin@...aid.com>
To:	Wei Yongjun <weiyj.lk@...il.com>
CC:	"yongjun_wei@...ndmicro.com.cn" <yongjun_wei@...ndmicro.com.cn>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] aoe: remove unused variable in resend()

Looks good, thanks.

On Oct 22, 2012, at 5:17 AM, Wei Yongjun wrote:

> From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> 
> The variable ah is initialized but never used
> otherwise, so remove the unused variable.
> 
> dpatch engine is used to auto generate this patch.
> (https://github.com/weiyj/dpatch)
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> ---
> drivers/block/aoe/aoecmd.c | 2 --
> 1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/block/aoe/aoecmd.c b/drivers/block/aoe/aoecmd.c
> index 3804a0a..812eb8a 100644
> --- a/drivers/block/aoe/aoecmd.c
> +++ b/drivers/block/aoe/aoecmd.c
> @@ -425,7 +425,6 @@ resend(struct aoedev *d, struct frame *f)
> 	struct sk_buff *skb;
> 	struct sk_buff_head queue;
> 	struct aoe_hdr *h;
> -	struct aoe_atahdr *ah;
> 	struct aoetgt *t;
> 	char buf[128];
> 	u32 n;
> @@ -440,7 +439,6 @@ resend(struct aoedev *d, struct frame *f)
> 		return;
> 	}
> 	h = (struct aoe_hdr *) skb_mac_header(skb);
> -	ah = (struct aoe_atahdr *) (h+1);
> 
> 	snprintf(buf, sizeof buf,
> 		"%15s e%ld.%d oldtag=%08x@...lx newtag=%08x s=%pm d=%pm nout=%d\n",
> 

-- 
  Ed Cashin
  ecashin@...aid.com


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/