linux-kernel - Re: [PATCH] [PATCH] extcon: driver model release call not needed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20121022195730.GB13640@kroah.com>
Date:	Mon, 22 Oct 2012 12:57:30 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	anish kumar <anish198519851985@...il.com>
Cc:	myungjoo.ham@...sung.com, cw00.choi@...sung.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [PATCH] extcon: driver model release call not needed

On Fri, Oct 19, 2012 at 02:12:06AM +0900, anish kumar wrote:
> From: anish kumar <anish198519851985@...il.com>
> 
> We don't need a release call in this file as we are doing
> everything needed in unregister call and we don't have any
> more pointer to free up.
> 
> Signed-off-by: anish kumar <anish198519851985@...il.com>
> ---
>  drivers/extcon/extcon-class.c |    4 +---
>  1 files changed, 1 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/extcon/extcon-class.c b/drivers/extcon/extcon-class.c
> index 946a318..cf30eb1 100644
> --- a/drivers/extcon/extcon-class.c
> +++ b/drivers/extcon/extcon-class.c
> @@ -585,9 +585,7 @@ static void extcon_cleanup(struct extcon_dev *edev, bool skip)
>  
>  static void extcon_dev_release(struct device *dev)
>  {
> -	struct extcon_dev *edev = (struct extcon_dev *) dev_get_drvdata(dev);
> -
> -	extcon_cleanup(edev, true);
> +	/* We don't have any thing to free here */
>  }

In the future (I know you fixed this up), doing an empty release()
function will get you in big trouble.  Please read the kobject
documentation for more information about why this is.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/