linux-kernel - Re: [PATCH 158/193] mm: remove CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5j+5m+Gj9aYJpkxA+GsRm3rg-RohD5n88amRbn634P=epw@mail.gmail.com>
Date:	Tue, 23 Oct 2012 16:11:47 -0700
From:	Kees Cook <keescook@...omium.org>
To:	David Rientjes <rientjes@...gle.com>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	Jan Beulich <JBeulich@...ell.com>, Mel Gorman <mel@....ul.ie>,
	Seth Jennings <sjenning@...ux.vnet.ibm.com>
Subject: Re: [PATCH 158/193] mm: remove CONFIG_EXPERIMENTAL

On Tue, Oct 23, 2012 at 3:46 PM, David Rientjes <rientjes@...gle.com> wrote:
> On Tue, 23 Oct 2012, Kees Cook wrote:
>
>> diff --git a/mm/Kconfig b/mm/Kconfig
>> index a3f8ddd..679945e 100644
>> --- a/mm/Kconfig
>> +++ b/mm/Kconfig
>> @@ -1,6 +1,5 @@
>>  config SELECT_MEMORY_MODEL
>>       def_bool y
>> -     depends on EXPERIMENTAL || ARCH_SELECT_MEMORY_MODEL
>>
>>  choice
>>       prompt "Memory model"
>
> This makes ARCH_SELECT_MEMORY_MODEL pointless, why keep it around?

Good point. This seems to trigger much deeper changes. All of these
and their logic go away:

arch/arm/Kconfig:config ARCH_SELECT_MEMORY_MODEL
arch/arm/mach-clps711x/Kconfig: select ARCH_SELECT_MEMORY_MODEL
arch/arm64/Kconfig:config ARCH_SELECT_MEMORY_MODEL
arch/ia64/Kconfig:config ARCH_SELECT_MEMORY_MODEL
arch/parisc/Kconfig:config ARCH_SELECT_MEMORY_MODEL
arch/powerpc/Kconfig:config ARCH_SELECT_MEMORY_MODEL
arch/s390/Kconfig:config ARCH_SELECT_MEMORY_MODEL
arch/sh/mm/Kconfig:config ARCH_SELECT_MEMORY_MODEL
arch/sparc/Kconfig:config ARCH_SELECT_MEMORY_MODEL
arch/x86/Kconfig:config ARCH_SELECT_MEMORY_MODEL

Along with mm/Kconfig:config SELECT_MEMORY_MODEL and associated logic.

How about we handle this as a phase 2, and for phase 1, I just drop
EXPERIMENTAL?

-Kees

-- 
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/