linux-kernel - Re: [PATCH 04/34] perf, x86: Support the TSX intx/intx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121023133300.GZ16230@one.firstfloor.org>
Date:	Tue, 23 Oct 2012 15:33:00 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Cc:	Andi Kleen <andi@...stfloor.org>, x86@...nel.org,
	linux-kernel@...r.kernel.org, acme@...hat.com, eranian@...gle.com,
	Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH 04/34] perf, x86: Support the TSX intx/intx_cp qualifiers

On Tue, Oct 23, 2012 at 02:09:19PM +0200, Peter Zijlstra wrote:
> On Thu, 2012-10-18 at 16:19 -0700, Andi Kleen wrote:
> > @@ -826,7 +827,8 @@ static inline bool intel_pmu_needs_lbr_smpl(struct perf_event *event)
> >                 return true;
> >  
> >         /* implicit branch sampling to correct PEBS skid */
> > -       if (x86_pmu.intel_cap.pebs_trap && event->attr.precise_ip > 1)
> > +       if (x86_pmu.intel_cap.pebs_trap && event->attr.precise_ip > 1 &&
> > +           x86_pmu.intel_cap.pebs_format < 2)
> >                 return true;
> >  
> >         return false; 
> 
> This seems unrelated to TSX, I suppose it belongs in the previous patch?

Ok will move.

-Andi

-- 
ak@...ux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/