linux-kernel - Re: [PATCH 06/34] perf, kvm: Support the intx/intx_cp modifiers in KVM arch perfmon emulation v2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121023133645.GB16230@one.firstfloor.org>
Date:	Tue, 23 Oct 2012 15:36:45 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	Peter Zijlstra <a.p.zijlstra@...llo.nl>, x86@...nel.org,
	linux-kernel@...r.kernel.org, acme@...hat.com, eranian@...gle.com,
	Andi Kleen <ak@...ux.intel.com>, avi@...hat.com,
	Gleb Natapov <gleb@...hat.com>
Subject: Re: [PATCH 06/34] perf, kvm: Support the intx/intx_cp modifiers in KVM arch perfmon emulation v2

On Tue, Oct 23, 2012 at 03:35:27PM +0200, Andi Kleen wrote:
> > So I forgot how all this worked, but will the KVM emulation not pass
> > this straight down to the hardware?
> 
> Pass down to perf. 
> 
> > 
> > Don't we have a problem where we're emulating arch perfmon v1 on AMD
> > hardware? On AMD hardware those bits do have meaning.
> 
> Ah they do? I wasn't aware. I can add a cpuid check for Intel I suppose.

Ah now I remember: I wrote it for the original qualifiers which would
have worked fine for AMD too. It just broke with the raw events you
asked for.

Ok will do the cpuid check to work around this problem.

-Andi


-- 
ak@...ux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/