linux-kernel - Re: fs: page cache wrongly left invalidated after revalidate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201210242111.q9OLBL28027212@msag502.nifty.com>
Date:	Thu, 25 Oct 2012 06:11:17 +0900
From:	MITSUNARI Shigeo <herumi@...ty.com>
To:	Jeff Moyer <jmoyer@...hat.com>
Cc:	linux-fsdevel@...r.kernel.org,
	Alexander Viro <viro@...iv.linux.org.uk>,
	linux-kernel@...r.kernel.org, Jens Axboe <axboe@...nel.dk>
Subject: Re: fs: page cache wrongly left invalidated after revalidate_disk

Jeff Moyer <jmoyer@...hat.com> writes:

> rescan_partitions (called in the bdev open path) should reset
> bd_invalidated.  I think you need to dig into why that isn't happening.

rescan_partitions() and invalidate_partitions() reset bd_invalidated
after calling check_disk_size_change(). But revalidate_disk() does not it.

So, I think bdev->bd_invalidated = 0 is necessary for revalidate_disk(),
or check_disk_size_change() should be it more simply.

Yours,
 Shigeo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/