linux-kernel - Re: fs: page cache wrongly left invalidated after revalidate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20121024163903.2a5bb819.akpm@linux-foundation.org>
Date:	Wed, 24 Oct 2012 16:39:03 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Jeff Moyer <jmoyer@...hat.com>
Cc:	MITSUNARI Shigeo <herumi@...ty.com>, linux-fsdevel@...r.kernel.org,
	Alexander Viro <viro@...iv.linux.org.uk>,
	linux-kernel@...r.kernel.org, Jens Axboe <axboe@...nel.dk>
Subject: Re: fs: page cache wrongly left invalidated after revalidate_disk

On Wed, 24 Oct 2012 09:44:23 -0400
Jeff Moyer <jmoyer@...hat.com> wrote:

> MITSUNARI Shigeo <herumi@...ty.com> writes:
> 
> > Hi, 
> >
> > We found that bdev->bd_invalidated was left set once revalidate_disk() 
> > is called, which results in page cache flush every time that device 
> > is open. 
> >
> > Specifically, we found this problem in MD block device.  Once we 
> > resize a MD device, mdadm --monitor periodically flush all page cache 
> > for that device every 60 or 1000 seconds when it opens the device. 
> >
> > This bug lies since at least 3.2.0 till the latest kernel(3.6.2). 
> > Patch is attached. 
> >
> > Anyone please review this?  Thanks in advance.
> 
> rescan_partitions (called in the bdev open path) should reset
> bd_invalidated.  I think you need to dig into why that isn't happening.

I suspect it's because I_NEW is no longer set on the inode.

I queued this one for some viro attention ;)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/