linux-kernel - Re: [PATCH 3/3] debugfs: break long lines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121026181238.GB25530@kroah.com>
Date:	Fri, 26 Oct 2012 11:12:38 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Yan Hong <clouds.yan@...il.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] debugfs: break long lines

On Sat, Oct 27, 2012 at 01:55:44AM +0800, Yan Hong wrote:
> 
> Signed-off-by: Yan Hong <clouds.yan@...il.com>
> ---
>  fs/debugfs/file.c  |   42 ++++++++++++++++++++++++++++--------------
>  fs/debugfs/inode.c |   10 ++++++----
>  2 files changed, 34 insertions(+), 18 deletions(-)
> 
> diff --git a/fs/debugfs/file.c b/fs/debugfs/file.c
> index 3915cc9..b37eee1 100644
> --- a/fs/debugfs/file.c
> +++ b/fs/debugfs/file.c
> @@ -95,10 +95,12 @@ struct dentry *debugfs_create_u8(const char *name, umode_t mode,
>  {
>  	/* if there are no write bits set, make read only */
>  	if (!(mode & S_IWUGO))
> -		return debugfs_create_file(name, mode, parent, value, &fops_u8_ro);
> +		return debugfs_create_file(name, mode, parent, value,
> +								&fops_u8_ro);

If you are going to do this (and hint, I really don't want you to), at
least make it look pretty:
		return debugfs_create_file(name, mode, parent, value,
					   &fops_u8_ro);

Other than that, I don't want to take this patch, sorry, it looks good
enough as-is.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/