linux-kernel - Re: [PATCH 2/3] debugfs: code clean and refactor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121026181259.GC25530@kroah.com>
Date:	Fri, 26 Oct 2012 11:12:59 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Yan Hong <clouds.yan@...il.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] debugfs: code clean and refactor

On Sat, Oct 27, 2012 at 01:55:43AM +0800, Yan Hong wrote:
> debug_fill_super():
> 	return directly if failed to allocate debugfs_fs_info.
> 
> __create_file():
> 	remove redundant initialization.
> 
> __debugfs_remove():
> 	remove redundant check.
> 	debugfs_positive() already checked dentry->inode is not NULL.

You did 3 different things, so that should be at least 3 different
patches.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/