linux-kernel - Re: [PATCH 1/5] debugfs: pass NULL as the last parameter of debugfs_print

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121027150715.GD3349@kroah.com>
Date:	Sat, 27 Oct 2012 08:07:15 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Yan Hong <clouds.yan@...il.com>
Cc:	linux-kernel@...r.kernel.org, Alessandro Rubini <rubini@...dd.com>
Subject: Re: [PATCH 1/5] debugfs: pass NULL as the last parameter of
 debugfs_print_regs32()

On Sat, Oct 27, 2012 at 04:05:25PM +0800, Yan Hong wrote:
> If 'prefix' is not used, pass NULL instead of empty string as the
> last parameter of debugfs_print_regs32().
> 
> Cc: Alessandro Rubini <rubini@...dd.com>
> 
> Signed-off-by: Yan Hong <clouds.yan@...il.com>
> ---
> 
> This function is only used (twice) by the author of it, and the
> 'prefix' feature is never used. But it's a well-documented debugfs
> API. It's added one year ago and appeared in many documents. I still
> prefer to let this API stay unchanged and treat the empty string as
> typo.

What "documents" did this appear in?  If the parameter isn't being used,
please, just delete it.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/