linux-kernel - Re: [PATCH 2/4] mfd: ab8500: add devicetree support for btemp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <508BF8F4.1060006@gmail.com>
Date:	Sat, 27 Oct 2012 17:08:36 +0200
From:	Francesco Lavra <francescolavra.fl@...il.com>
To:	"Rajanikanth H.V" <rajanikanth.hv@...ricsson.com>
CC:	lee.jones@...aro.org, arnd@...db.de, anton.vorontsov@...aro.org,
	linus.walleij@...ricsson.com, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org, linaro-dev@...ts.linaro.org,
	patches@...aro.org, STEricsson_nomadik_linux@...t.st.com
Subject: Re: [PATCH 2/4] mfd: ab8500: add devicetree support for btemp

On 10/25/2012 08:30 AM, Rajanikanth H.V wrote:
> From: "Rajanikanth H.V" <rajanikanth.hv@...ricsson.com>
> 
> This patch adds device tree support for
> battery-temperature-monitor driver
> 
> Signed-off-by: Rajanikanth H.V <rajanikanth.hv@...ricsson.com>
> ---
>  Documentation/devicetree/bindings/mfd/ab8500.txt   |    6 ++
>  .../bindings/power_supply/ab8500/btemp.txt         |   16 +++++
>  arch/arm/boot/dts/dbx5x0.dtsi                      |    5 ++
>  drivers/mfd/ab8500-core.c                          |    5 ++
>  drivers/power/Kconfig                              |    6 --
>  drivers/power/ab8500_bmdata.c                      |    4 +-
>  drivers/power/ab8500_btemp.c                       |   66 ++++++++++++--------
>  7 files changed, 73 insertions(+), 35 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/power_supply/ab8500/btemp.txt
> 
> diff --git a/Documentation/devicetree/bindings/mfd/ab8500.txt b/Documentation/devicetree/bindings/mfd/ab8500.txt
> index 6ca8d81..179c802 100644
> --- a/Documentation/devicetree/bindings/mfd/ab8500.txt
> +++ b/Documentation/devicetree/bindings/mfd/ab8500.txt
> @@ -30,6 +30,12 @@ ab8500-fg                : 			: vddadc       : Fuel Gauge
>  			 : LOW_BAT_F		:	       : LOW threshold battery voltage
>  			 : CC_INT_CALIB		:	       : Coulomb Counter Internal Calibration
>  			 : CCEOC		:	       : Coulomb Counter End of Conversion
> +ab8500-btemp		 :			: vtvout       : Battery Temperature
> +			 : BAT_CTRL_INDB        :              : Battery Removal Indicator
> +			 : BTEMP_LOW            :              : Btemp < BtempLow, if battery temperature is lower than -10°C
> +			 : BTEMP_HIGH           :              : BtempLow < Btemp < BtempMedium,if battery temperature is between -10 and 0°C
> +			 : BTEMP_LOW_MEDIUM     :              : BtempMedium < Btemp < BtempHigh,if battery temperature is between 0°C and“MaxTemp
> +			 : BTEMP_MEDIUM_HIGH    :	       : Btemp > BtempHigh, if battery temperature is higher than “MaxTemp”

BTEMP_HIGH, BTEMP_LOW_MEDIUM and BTEMP_MEDIUM_HIGH are in the wrong
order and don't correspond to their description.

--
Francesco
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/