linux-kernel - Re: [PATCH v5] serial/arc-uart: Add new driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 27 Oct 2012 12:24:46 +0530
From:	Vineet Gupta <Vineet.Gupta1@...opsys.com>
To:	<balbi@...com>
CC:	<gregkh@...uxfoundation.org>, <alan@...ux.intel.com>,
	<arc-linux-dev@...opsys.com>, <linux-serial@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5] serial/arc-uart: Add new driver

On Friday 26 October 2012 05:40 PM, Felipe Balbi wrote:
> On Fri, Oct 26, 2012 at 05:33:16PM +0530, Vineet.Gupta1@...opsys.com wrote:
>> +/*
>> + * Release the memory region(s) being used by 'port'.
>> + */
>> +static void arc_serial_release_port(struct uart_port *port)
>> +{
>> +}
>> +
>> +/*
>> + * Request the memory region(s) being used by 'port'.
>> + */
>> +static int arc_serial_request_port(struct uart_port *port)
>> +{
>> +	return 0;
>> +}
>> +
>> +/*
>> + * Verify the new serial_struct (for TIOCSSERIAL).
>> + */
>> +static int
>> +arc_serial_verify_port(struct uart_port *port, struct serial_struct *ser)
>> +{
>> +	return 0;
>> +}
> why all these empty functions with wrong comments above them ??

Actually serial_core.c invokes the reqest/release callbacks w/o
verifying for a NULL pointer check. Thus they need to be in there even
if empty. I've removed the offending comments though !

-Vineet
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/