[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <alpine.LNX.2.00.1210290942150.19184@pobox.suse.cz>
Date: Mon, 29 Oct 2012 09:43:34 +0100 (CET)
From: Jiri Kosina <jkosina@...e.cz>
To: David Härdeman <david@...deman.nu>
Cc: Stephen Rothwell <sfr@...b.auug.org.au>,
Mauro Carvalho Chehab <mchehab@...radead.org>,
linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
Bruno Prémont <bonbons@...ux-vserver.org>
Subject: Re: linux-next: build failure after merge of the v4l-dvb tree
On Mon, 29 Oct 2012, David Härdeman wrote:
> > allmodconfig) failed like this:
> >
> > drivers/hid/hid-picolcd_cir.c: In function 'picolcd_init_cir':
> > drivers/hid/hid-picolcd_cir.c:119:27: error: 'RC_TYPE_ALL' undeclared
> > (first use in this function)
>
> I can fix it, should be easy (rename RC_TYPE_ALL to RC_BIT_ALL).
>
> > Caused by commit c003ab1bedf0 ("[media] rc-core: add separate defines
> for
> > protocol bitmaps and numbers"). The new reference was introduced in
> > commit ae08e324146c ("HID: picoLCD: Add support for CIR") which was
> > merged by Linus on October 2 into v3.7-rc1 via the hid tree.
> >
> > I have used the v4l-dvb tree from next-20121026 for today.
>
> The question is in which form you want the patch - as a separate patch or
> a new version of commit c003ab1bedf0 (i.e. the entire patch)? Also, against
> which tree should I create the patch?
I am not able to see c003ab1bedf0 in repo at
git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media.git
so I am not entirely sure what's happening, but I guess that you have just
changed the define for RC_TYPE_ALL and updated all the drivers under
drivers/media to use the new name. So please do so for
drivers/hid/hid-picolcd_cir.c the same way.
Thanks,
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists