linux-kernel - Re: [PATCH] cpuidle: add missing header include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <002101cdb572$fcc4d670$f64e8350$%han@samsung.com>
Date:	Mon, 29 Oct 2012 10:16:13 +0900
From:	Jingoo Han <jg1.han@...sung.com>
To:	'Daniel Lezcano' <daniel.lezcano@...aro.org>
Cc:	"'Rafael J. Wysocki'" <rafael.j.wysocki@...el.com>,
	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
	'Jingoo Han' <jg1.han@...sung.com>
Subject: Re: [PATCH] cpuidle: add missing header include

On Monday, October 29, 2012 6:49 AM Marek Vasut wrote
> 
> On 10/26/2012 06:30 AM, Jingoo Han wrote:
> > This patch adds missing device.h header to fix build warnings as below:
> >
> > drivers/cpuidle/cpuidle.h:26:41: warning: 'struct device' declared inside parameter list [enabled by
> default]
> > drivers/cpuidle/cpuidle.h:26:41: warning: its scope is only this definition or declaration, which is
> probably not what you want
> > [enabled by default]
> > drivers/cpuidle/cpuidle.h:27:45: warning: 'struct device' declared inside parameter list [enabled by
> default]
> > In file included from drivers/cpuidle/driver.c:15:0:
> > drivers/cpuidle/cpuidle.h:26:41: warning: 'struct device' declared inside parameter list [enabled by
> default]
> > drivers/cpuidle/cpuidle.h:26:41: warning: its scope is only this definition or declaration, which is
> probably not what you want
> > [enabled by default]
> > drivers/cpuidle/cpuidle.h:27:45: warning: 'struct device' declared inside parameter list [enabled by
> default]
> >
> > This build warning is introduced by commit efeca1b
> > "cpuidle / sysfs: change function parameter".
> >
> > Signed-off-by: Jingoo Han <jg1.han@...sung.com>
> > Cc: Daniel Lezcano <daniel.lezcano@...aro.org>
> > ---
> 
> Jingoo, could you copy-pastebin your config file. I don't have this
> warning and I would like to understand why.

Hi Daniel Lezcano,

Could you build the code by using GCC 4.6.x?
In my opinion, it would be better.

Also, my config option is as below:
    make exynos4_defconfig + CONFIG_CPU_IDLE

Best regards,
Jingoo Han


> 
> Thanks
>   -- Daniel
> 
> >  drivers/cpuidle/cpuidle.h |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/cpuidle/cpuidle.h b/drivers/cpuidle/cpuidle.h
> > index a5bbd1c..2120d9e 100644
> > --- a/drivers/cpuidle/cpuidle.h
> > +++ b/drivers/cpuidle/cpuidle.h
> > @@ -5,6 +5,8 @@
> >  #ifndef __DRIVER_CPUIDLE_H
> >  #define __DRIVER_CPUIDLE_H
> >
> > +#include <linux/device.h>
> > +
> >  /* For internal use only */
> >  extern struct cpuidle_governor *cpuidle_curr_governor;
> >  extern struct list_head cpuidle_governors;
> 
> 
> --
>  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
> 
> Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
> <http://twitter.com/#!/linaroorg> Twitter |
> <http://www.linaro.org/linaro-blog/> Blog

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/