| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20121029145423.GF6754@infradead.org> Date: Mon, 29 Oct 2012 12:54:23 -0200 From: Arnaldo Carvalho de Melo <acme@...hat.com> To: Feng Tang <feng.tang@...el.com> Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...e.hu>, Namhyung Kim <namhyung@...nel.org>, Andi Kleen <andi@...stfloor.org>, linux-kernel@...r.kernel.org Subject: Re: [PATCH v5 5/8] perf ui/browser: Integrate script browser into main hists browser Em Tue, Oct 30, 2012 at 11:56:06AM +0800, Feng Tang escreveu: > Integrate the script browser into "perf report" framework, users can > use function key 'r' or the drop down menu to list all perf scripts > and select one of them, just like they did for the annotation. > > Signed-off-by: Feng Tang <feng.tang@...el.com> I noticed this comment on another patch: -------------------------- This initial version only enables it for 'perf report', by checking the "timer" parameter of perf_evsel__hists_browser() equals NULL. -------------------------- Yeah, one can say that if a timer is provided, we can say its 'top' and not 'report', at least as things stand now. So please add a 'is_top(void *timer)' so that we know the intent more clearly and use it to avoid showing the 'r' key when in 'top' mode, ok? - Arnaldo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists