linux-kernel - Re: [PATCH 1/2] Helper macros used for replacing the use of VLAIS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121030194045.GA14892@kroah.com>
Date:	Tue, 30 Oct 2012 12:40:45 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Behan Webster <behanw@...verseincode.com>
Cc:	balbi@...com, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] Helper macros used for replacing the use of VLAIS

On Tue, Oct 30, 2012 at 03:35:24PM -0400, Behan Webster wrote:
> On 12-10-30 03:20 PM, Greg KH wrote:
> >On Tue, Oct 30, 2012 at 02:25:19PM -0400, Behan Webster wrote:
> >>The use of variable length arrays in structs (VLAIS) in the Linux Kernel code
> >>precludes the use of compilers which don't implement VLAIS (for instance the
> >>Clang compiler). This new header file contains macros which can be used to
> >>calculate the size and offset of variables in an allocated buffer of memory
> >>taking into account alignment issues.
> >>
> >>Signed-off-by: Behan Webster <behanw@...verseincode.com>
> >>---
> >>  include/linux/valign.h |   87 ++++++++++++++++++++++++++++++++++++++++++++++++
> >>  1 file changed, 87 insertions(+)
> >>  create mode 100644 include/linux/valign.h
> >You sent the same patch here, to two different trees (usb and
> >networking).  That's not good, what happens if they both apply them?
> Good point. My mistake.
> 
> People in both subsystems needed to see the patch which is why I sent them.
> 
> What would have been a better approach? And how can I fix this?

Send all 3 as a single series, to everyone and ask the different
maintainers to work together to figure out who is going to apply what.

Yeah, it's tough, but things like this are pretty rare, so they don't
come up often.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/