linux-kernel - Re: [PATCH 8/9] trace: use this_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0000013ab7f1e47a-68c5ce3c-06bb-48f8-93f7-1ce012b36a75-000000@email.amazonses.com>
Date:	Wed, 31 Oct 2012 17:50:14 +0000
From:	Christoph Lameter <cl@...ux.com>
To:	Shan Wei <shanwei88@...il.com>
cc:	rostedt@...dmis.org, fweisbec@...il.com,
	Kernel-Maillist <linux-kernel@...r.kernel.org>, mingo@...hat.com
Subject: Re: [PATCH 8/9] trace: use this_cpu_ptr per-cpu helper

On Wed, 31 Oct 2012, Shan Wei wrote:

> From: Shan Wei <davidshan@...cent.com>
>
>
> Signed-off-by: Shan Wei <davidshan@...cent.com>
> ---
>  kernel/trace/blktrace.c |    2 +-
>  kernel/trace/trace.c    |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c
> index c0bd030..71259e2 100644
> --- a/kernel/trace/blktrace.c
> +++ b/kernel/trace/blktrace.c
> @@ -147,7 +147,7 @@ void __trace_note_message(struct blk_trace *bt, const char *fmt, ...)
>  		return;
>
>  	local_irq_save(flags);
> -	buf = per_cpu_ptr(bt->msg_data, smp_processor_id());
> +	buf = this_cpu_ptr(bt->msg_data);
>  	va_start(args, fmt);
>  	n = vscnprintf(buf, BLK_TN_MAX_MSG, fmt, args);
>  	va_end(args);

Ok

> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> index 31e4f55..81ae35b 100644
> --- a/kernel/trace/trace.c
> +++ b/kernel/trace/trace.c
> @@ -1513,7 +1513,7 @@ static char *get_trace_buf(void)
>  	if (!percpu_buffer)
>  		return NULL;
>
> -	buffer = per_cpu_ptr(percpu_buffer, smp_processor_id());
> +	buffer = this_cpu_ptr(percpu_buffer);
>
>  	return buffer->buffer;


Just do a

	return this_cpu_read(percpu_buffer->buffer);

and get rid of the this_cpu_ptr op
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/