linux-kernel - Re: [PATCH 8/9] trace: use this_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5093E5FF.5050000@gmail.com>
Date:	Fri, 02 Nov 2012 23:25:51 +0800
From:	Shan Wei <shanwei88@...il.com>
To:	Christoph Lameter <cl@...ux.com>
CC:	rostedt@...dmis.org, fweisbec@...il.com,
	Kernel-Maillist <linux-kernel@...r.kernel.org>, mingo@...hat.com
Subject: Re: [PATCH 8/9] trace: use this_cpu_ptr per-cpu helper

Christoph Lameter said, at 2012/11/1 1:50:
>>
>> -	buffer = per_cpu_ptr(percpu_buffer, smp_processor_id());
>> +	buffer = this_cpu_ptr(percpu_buffer);
>>
>>  	return buffer->buffer;
> 
> 
> Just do a
> 
> 	return this_cpu_read(percpu_buffer->buffer);
> 
> and get rid of the this_cpu_ptr op

can not do that.
kernel/trace/trace.c:1515: error: incompatible types when assigning to type 'char[1024]' from type 'char *'

 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/