linux-kernel - Re: [PATCH] usb: gadget: ncm: correct endianess conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5093B29B.8070000@mvista.com>
Date:	Fri, 02 Nov 2012 15:46:35 +0400
From:	Sergei Shtylyov <sshtylyov@...sta.com>
To:	Dmytro Milinevskyy <milinevskyy@...il.com>
CC:	Felipe Balbi <balbi@...com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: gadget: ncm: correct endianess conversion

Hello.

On 01-11-2012 19:16, Dmytro Milinevskyy wrote:

> Convert USB descriptor's fields to CPU byte order before using locally in USB
> NCM gadget driver.
> Tested on MIPS32 big-endian device.

> Signed-off-by: Dmytro Milinevskyy <milinevskyy@...il.com>
> ---
>   drivers/usb/gadget/f_ncm.c | 12 ++++++++----
>   1 file changed, 8 insertions(+), 4 deletions(-)

> diff --git a/drivers/usb/gadget/f_ncm.c b/drivers/usb/gadget/f_ncm.c
> index b651b52..a7cdd47 100644
> --- a/drivers/usb/gadget/f_ncm.c
> +++ b/drivers/usb/gadget/f_ncm.c
[...]
> @@ -869,15 +869,19 @@ static struct sk_buff *ncm_wrap_ntb(struct gether *port,
>       struct sk_buff    *skb2;
>       int        ncb_len = 0;
>       __le16        *tmp;
> -    int        div = ntb_parameters.wNdpInDivisor;
> -    int        rem = ntb_parameters.wNdpInPayloadRemainder;
> +    int        div;
> +    int        rem;
>       int        pad;
> -    int        ndp_align = ntb_parameters.wNdpInAlignment;
> +    int        ndp_align;
>       int        ndp_pad;
>       unsigned    max_size = ncm->port.fixed_in_len;
>       struct ndp_parser_opts *opts = ncm->parser_opts;
>       unsigned    crc_len = ncm->is_crc ? sizeof(uint32_t) : 0;
>   +    div = le16_to_cpu(ntb_parameters.wNdpInDivisor);

     Probably corrupt patch -- there shouldn't be spaces before '+'.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/