[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAOUdcc-5TdxUzysEvacexmDQ6stB7kNo18-B3Y26V8i7i+p-HA@mail.gmail.com>
Date: Sun, 4 Nov 2012 15:30:05 +0100
From: Dmytro Milinevskyy <milinevskyy@...il.com>
To: Sergei Shtylyov <sshtylyov@...sta.com>
Cc: Felipe Balbi <balbi@...com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: gadget: ncm: correct endianess conversion
Hum, you are right. It's pain to send anything via thunderbird.
Resending.
br,
-- dmytro
On Fri, Nov 2, 2012 at 12:46 PM, Sergei Shtylyov <sshtylyov@...sta.com> wrote:
> Hello.
>
>
> On 01-11-2012 19:16, Dmytro Milinevskyy wrote:
>
>> Convert USB descriptor's fields to CPU byte order before using locally in
>> USB
>> NCM gadget driver.
>> Tested on MIPS32 big-endian device.
>
>
>> Signed-off-by: Dmytro Milinevskyy <milinevskyy@...il.com>
>> ---
>> drivers/usb/gadget/f_ncm.c | 12 ++++++++----
>>
>> 1 file changed, 8 insertions(+), 4 deletions(-)
>
>
>> diff --git a/drivers/usb/gadget/f_ncm.c b/drivers/usb/gadget/f_ncm.c
>> index b651b52..a7cdd47 100644
>> --- a/drivers/usb/gadget/f_ncm.c
>> +++ b/drivers/usb/gadget/f_ncm.c
>
> [...]
>>
>> @@ -869,15 +869,19 @@ static struct sk_buff *ncm_wrap_ntb(struct gether
>> *port,
>>
>> struct sk_buff *skb2;
>> int ncb_len = 0;
>> __le16 *tmp;
>> - int div = ntb_parameters.wNdpInDivisor;
>> - int rem = ntb_parameters.wNdpInPayloadRemainder;
>> + int div;
>> + int rem;
>>
>> int pad;
>> - int ndp_align = ntb_parameters.wNdpInAlignment;
>> + int ndp_align;
>> int ndp_pad;
>>
>> unsigned max_size = ncm->port.fixed_in_len;
>> struct ndp_parser_opts *opts = ncm->parser_opts;
>> unsigned crc_len = ncm->is_crc ? sizeof(uint32_t) : 0;
>> + div = le16_to_cpu(ntb_parameters.wNdpInDivisor);
>
>
> Probably corrupt patch -- there shouldn't be spaces before '+'.
>
> WBR, Sergei
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists